refactor: change event schema #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage ? 91.59%
=======================================
Files ? 30
Lines ? 369
Branches ? 68
=======================================
Hits ? 338
Misses ? 30
Partials ? 1 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justinhynes
reviewed
Aug 3, 2023
| title: rec.title, | ||
| courserun_key: rec.active_run_key, | ||
| label: rec.active_run_key || `${rec.title} [${rec.uuid}]`, |
There was a problem hiding this comment.
This little bit of naming logic is duplicated and also important. Should we add a comment that if the label is changed that we should also update productLabel in RecommendationCard.jsx (and vice-versa)?
Not sure if it would ever change... but seems like it would cause a weird mismatch and may be hard to track down?
There was a problem hiding this comment.
Good call out! I'll add a comment in both places. The schema is bound to be modified again so it'll be nice to have the reminder
justinhynes
approved these changes
Aug 3, 2023
MaxFrank13
force-pushed
the
mfrank/2699-changes-to-event-schema
branch
from
8f0a24d
to
f9b649c
Compare
MaxFrank13
force-pushed
the
mfrank/2699-changes-to-event-schema
branch
from
f9b649c
to
e724412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made changes to our event schema for experiment V1 of the Skills Builder.
This PR adds in those changes and modifies any tests as necessary to fit the new schema.
APER-2699